Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add discontinued incomes section #33264

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Add discontinued incomes section #33264

merged 7 commits into from
Dec 4, 2024

Conversation

ToddWebDev
Copy link
Contributor

@ToddWebDev ToddWebDev commented Nov 27, 2024 •
edited
Loading

Did you change site-wide styles, platform utilities or other infrastructure?

  • No
  • Yes

Summary

Import Discontinued Incomes - Section 11 into the Income & Asset Statement form (21P-0969)

Issue

Associated Pull Request(s)

n/a

How to run in local environment

  1. Check out this branch locally
  2. Run vets-website and vets-api
  3. In your local environment, set the income_and_assets_form_enabled flipper to 'enabled' at http://localhost:3000/flipper/features/income_and_assets_form_enabled
  4. Go to http://localhost:3001/income-and-asset-statement-form-21p-0969/ in your browser

How to verify

  1. Go to chapter 11 - Discontinued Incomes (/discontinued-incomes-summary)
  2. Verify that an discontinued income can be added, edited, and deleted
  3. Verify that discontinued incomes are displayed on the 'Review' page

What areas of the site does it impact?

Income & Asset Statement Application

Screenshots

Desktop

Summary Page

No Incomes Incomes
localhost_3001_income-and-asset-statement-form-21p-0969_ (21) localhost_3001_income-and-asset-statement-form-21p-0969_ (28)

Item Pages

Relationship Payer Type
localhost_3001_income-and-asset-statement-form-21p-0969_form-saved (15) localhost_3001_income-and-asset-statement-form-21p-0969_form-saved (16) localhost_3001_income-and-asset-statement-form-21p-0969_ (24)
Frequency Date Amount
localhost_3001_income-and-asset-statement-form-21p-0969_ (25) localhost_3001_income-and-asset-statement-form-21p-0969_ (26) localhost_3001_income-and-asset-statement-form-21p-0969_ (27)

Quality Assurance & Testing

  • New unit tests (if applicable)
  • New E2E tests added (if applicable)
  • Existing unit tests and integration tests are passing
  • Existing E2E tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot style, layout and content matches the design references
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/income-and-asset-86454-discontinued-incomes/main December 2, 2024 16:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/income-and-asset-86454-discontinued-incomes/main December 2, 2024 17:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/income-and-asset-86454-discontinued-incomes/main December 2, 2024 22:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/income-and-asset-86454-discontinued-incomes/main December 3, 2024 15:29 Inactive
@ToddWebDev ToddWebDev linked an issue Dec 3, 2024 that may be closed by this pull request
Section XI: Discontinued or irregular income department-of-veterans-affairs/va.gov-team#86454
Closed
@mjknight50 mjknight50 marked this pull request as ready for review December 4, 2024 21:00
@mjknight50 mjknight50 requested review from a team as code owners December 4, 2024 21:00
mjknight50
mjknight50 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@ToddWebDev ToddWebDev added the pension-income-assets Used for PRs that impact the 21P-0969 form label Dec 4, 2024
@ToddWebDev ToddWebDev merged commit e5a7c72 into main Dec 4, 2024
75 of 76 checks passed
@ToddWebDev ToddWebDev deleted the income-and-asset-86454-discontinued-incomes branch December 4, 2024 21:26
Thrillberg pushed a commit that referenced this pull request Dec 9, 2024
@ToddWebDev @Thrillberg
Add discontinued incomes section (#33264)
ac4631c 
* Add discontinued incomes section

* Update cypress test

* Rename item page

* Add recipient name page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjknight50 mjknight50 mjknight50 approved these changes

Assignees
No one assigned
Labels
pension-income-assets Used for PRs that impact the 21P-0969 form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Section XI: Discontinued or irregular income
3 participants
@ToddWebDev @mjknight50 @va-vfs-bot